Add allow-list support to resolve and rpmtree #3
+40
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to allowing a set of packages that are not allowed, we should allow the scope to be narrowed to a set of packages that is allowed. This change adds the `--only-allow` option to both `resolve` and `rpmtree` commands to achieve this outcome.
wade-arista
reviewed
Jan 3, 2025
| @@ -1229,7 +1229,7 @@ func Test(t *testing.T) { | |||
| for i, _ := range repo.Packages { | |||
| packages = append(packages, &repo.Packages[i]) | |||
| } | |||
| err = resolver.LoadInvolvedPackages(packages, nil) | |||
| err = resolver.LoadInvolvedPackages(packages, nil, nil) | |||
There was a problem hiding this comment.
test case where it's not nil?
This change tweaks a few bits in the earlier changes to make things a little nicer: * clean up the flag help * fixes the comments for LoadInvolvedPackages * abort the allowed matcher loop early if we get a match * re-works the allow/ignore code structure to reduce duplication
wade-arista
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to allowing a set of packages that are not allowed, we should allow the scope to be narrowed to a set of packages that is allowed. This change adds the
--only-allowoption to bothresolveandrpmtreecommands to achieve this outcome.